Proposal: Dev & CI workflow improvement #1354
Conversation
noirbizarre
force-pushed
the
build/poe
branch
from
976aaa2 to
b304237
Compare
…try dependencies groups in ci Fix commitizen-tools#724
…Python versions using `tox`
noirbizarre
force-pushed
the
build/poe
branch
from
b304237 to
6e542f0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1354 +/- ##
==========================================
+ Coverage 97.33% 97.55% +0.21%
==========================================
Files 42 55 +13
Lines 2104 2617 +513
==========================================
+ Hits 2048 2553 +505
- Misses 56 64 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
I love this! Would love to know how @woile before reviewing it. Another idea I had was to migrate to uv, but looking at this awesome PR. hmmm.. we probably should stay in poetry. Will try to take a deeper look |
|
LGTM, I've also been interested in trying |
|
Great, I am going to merge this one 👌🏼 I can try submitting a new PR for switching to Migrating should be simple:
So it'really straightforward now. If you are interested, I can do a PR. However, we would lose Dependabot support until dependabot/dependabot-core#10478 is done |
Yep, we don't really need to. I mentioned it simply because Airflow is using it and I recently migrate my personal workflow to uv (still have some poetry part though).
The last time I check it was still draft and now it's final! just notice there's a PR for pep 735 support
I guess we'll just use hatch if we're to change to uv
yep, this is one major downside. I probably would say we don't really need to migrate to uv unless someone is really interested in making it happen. |
| PYPI_PASSWORD: ${{ secrets.PYPI_PASSWORD }} | ||
| run: | | ||
| ./scripts/publish | ||
| POETRY_HTTP_BASIC_PYPI_USERNAME: ${{ secrets.PYPI_USERNAME }} |
There was a problem hiding this comment.
We probably could migrate to trusted publisher in the future
| packages = [{ include = "commitizen" }, { include = "commitizen/py.typed" }] | ||
|
|
||
| [tool.poetry.requires-plugins] | ||
| "poethepoet" = ">=0.32.2" |
There was a problem hiding this comment.
The last time I tried this when testing project template generation, it worked weirdly. I probably should try it again. maybe it's fixed
| ] | ||
|
|
||
| [tool.tox] | ||
| requires = ["tox>=4.22"] |
There was a problem hiding this comment.
should we make it consistent with tox = ">4"
3 participants
Description
This PR is a proposal improvement on the dev & CI workflows:
poethepoetas plugin to run taskstoxsupport to easily test against all supported Python versionpre-pushhooks as they already run on commitOn
poetry install,poethepoetis installed locally as a plugin.Tasks are exposed both as:
You can run:
Tasks accept extra parameters, so it's now possible to run tests with queries:
poetry test -k bumpSo are tox tests (run in parallel)
To run the same thing as in GitHub action, run
poetry ciYou can also preview the documentation with
poetry docAvailable tasks
Checklist
./scripts/formatand./scripts/testlocally to ensure this change passes linter check and testExpected behavior
--no-verify(pre-commit hooks are lighter and don't prevent push wip branches or in case of flapping test)Steps to Test This Pull Request
poetry installpoetry listorpoe(poetry run poeif you don't have it globally installed)Additional context
Fix #724
Note
It makes possible to have the documentation screenshots easily generated on the fly in both GHA workflow and
poetry doccommand and so, not having commit them and to store them in the repo